Improved test of supporting of nullable serializer in UserSerializers annotation #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandwwraith
approved these changes
Nov 23, 2020
shanshin
force-pushed
the
use-serializers-not-null-984
branch
from
93eb5b1
to
1c1a92e
Compare
… annotation (Fixes #984)
shanshin
force-pushed
the
use-serializers-not-null-984
branch
from
1c1a92e
to
e2ebb31
Compare
sandwwraith
reviewed
Dec 24, 2020
| @@ -38,7 +38,7 @@ tasks.withType(Jar).named(kotlin.jvm().artifactsTaskName) { | |||
| manifest { | |||
| attributes( | |||
| "Implementation-Version": version, | |||
| "Require-Kotlin-Version": "1.4-RC", | |||
| "Require-Kotlin-Version": "1.4.30-M1", | |||
There was a problem hiding this comment.
NB: bug fixes do not require raising minimal kotlin version, but for this case, we wanted to do it anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #984